[uss_qualifier/scenarios/netrid/nominal_behavior] Add checks for UA classification in SP (NET0260) #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lassification in SP (NET0260)
mickmis
force-pushed
the
uaclassification/sp
branch
from
f82aa54 to
a8af531
Compare
Shastick
suggested changes
Jan 6, 2025
| @@ -651,3 +673,209 @@ def _evaluate_operational_status( | |||
| key="skip_reason", | |||
| message=f"Unsupported version {self._rid_version}: skipping Operational Status evaluation", | |||
| ) | |||
|
|
|||
| def _evaluate_ua_type( | |||
There was a problem hiding this comment.
The call to this function is missing (presumably in evaluate_sp_details)
| query_timestamps=[query_timestamp], | ||
| ) | ||
|
|
||
| equivalent = {injection.UAType.HybridLift, injection.UAType.VTOL} |
There was a problem hiding this comment.
A little comment explaining this might help us in the future
Comment on lines
+729
to
+736
| try: | ||
| injection.UAType(observed_val) | ||
| except ValueError: | ||
| check.record_failed( | ||
| "UA type is invalid", | ||
| details=f"USS returned an invalid UA type: {observed_val}.", | ||
| query_timestamps=[query_timestamp], | ||
| ) |
There was a problem hiding this comment.
Can we actually reach this code if observed_val is invalid? I would assume that if it is invalid, it was different than injected_val?
Or do we expect injected_val to take invalid values?
Comment on lines
+811
to
+822
| injected_eu_category = injected_eu_classification.get("category") | ||
| injected_eu_class = injected_eu_classification.get("class") | ||
| observed_eu_category = ( | ||
| observed_eu_classification.get("category") | ||
| if observed_eu_classification | ||
| else None | ||
| ) | ||
| observed_eu_class = ( | ||
| observed_eu_classification.get("class") | ||
| if observed_eu_classification | ||
| else None | ||
| ) |
There was a problem hiding this comment.
Given that we compare the classification dicts earlier (with injected_classification_fields != observed_classification_fields:), would we not fail at an earlier stage? (Although, I see that the severity level is of 'warning', so the additional details may be welcome)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the checks for UA classification and UA classification type exposed by SP (requirements NET0260,Table1,3 and NET0260,Table1,4).